Add command builder with escaped user input#5982
Merged
AmelBawa-msft merged 9 commits intomicrosoft:masterfrom Jan 23, 2026
Merged
Add command builder with escaped user input#5982AmelBawa-msft merged 9 commits intomicrosoft:masterfrom
AmelBawa-msft merged 9 commits intomicrosoft:masterfrom
Conversation
AmelBawa-msft
commented
Jan 15, 2026
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
reviewed
Jan 22, 2026
Member
JohnMcPMS
left a comment
JohnMcPMS
left a comment
There was a problem hiding this comment.
Add the tests to the pipeline as well so that we get coverage.
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs
Outdated
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs
Outdated
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs
Outdated
Show resolved
Hide resolved
JohnMcPMS
previously approved these changes
Jan 23, 2026
JohnMcPMS
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StartInfo.ArgumentListis not available in net48, hence manually implementing the escape method.Microsoft Reviewers: Open in CodeFlow